feat(harness): per-row delegate Edit and Remove in detail pane#251
Merged
Conversation
Adds the row-level affordances for delegates that mirror what we just shipped for includes — ••• menu with Edit / Remove on each delegate card, gated to non-registry harnesses, plus the underlying YNH wrapper. The "Add Delegate" entry point is intentionally absent. The first attempt landed an inline embed that didn't fit how users actually think about picking a delegate target (a harness already in their library, not a path to type or browse to). That flow will be reintroduced once we agree on a unified source-picker pattern that covers Add Include, Add Delegate, Add Marketplace, and Install Harness consistently. What's in: - DelegateMutator service (ynh delegate add / remove / update) - HarnessDelegateEditor coordinator for per-row Edit and Remove - EditDelegateSheet (ref + path text fields + command preview) - Per-row ••• menu on delegate cards in HarnessDetailDependencyView - Remove confirmation dialog - Strings translated across all 40 supported languages What's deliberately missing (deferred): - "Add Delegate" entry point — depends on unified picker design Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eyelock
force-pushed
the
feat/harness-delegate-editor
branch
from
9f6f1df to
cff3180
Compare
eyelock
changed the title
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Edit and Remove affordances on each delegate card in the harness detail pane, gated to non-registry harnesses. Mirrors the per-row include affordances shipped in #250.
The "Add Delegate" entry point is deferred. An attempt to land it as an inline embed didn't fit how users pick a delegate (typically a harness already in the library, not a URL or path to type). That flow will be reintroduced once a unified source-picker pattern exists for Add Include, Add Delegate, Add Marketplace, and Install Harness.
What's in
DelegateMutator— wrapsynh delegate add / remove / updateHarnessDelegateEditor— coordinator for per-row Edit and RemoveEditDelegateSheet— ref + path fields with command previewTest plan