fix(release): Add missing Info.plist creation to release workflow#28
Merged
Conversation
The GitHub Actions release workflow was missing the step to create Info.plist in the app bundle. This caused: - About page to show blank (Bundle.main.infoDictionary was nil) - App icon not displaying (CFBundleIconFile not set) - Potential issues with bundle identifier-dependent features Now copies Info.plist.template and sets CFBundleShortVersionString and CFBundleVersion (git commit SHA) using plutil, matching the Makefile's release-app target behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The release workflow was missing the step to create
Info.plistfrom template with version and commit SHA. The local Makefile had this correctly, but it wasn't replicated in the GitHub Actions workflow.Changes
Added 4 lines to
.github/workflows/release.ymlin the "Create app bundle" step:Info.plist.templateto app bundleCFBundleShortVersionStringfrom release tagCFBundleVersionfrom git commit SHATest Plan
🤖 Generated with Claude Code