fix(window): Enforce single window to prevent blank terminals#57
Merged
Conversation
Multiple windows cause terminal views to appear blank because NSView can only have one parent. When two windows display the same terminal, the view gets "stolen" from one window to another. Changes: - Remove "New Window" menu command (Cmd+N now creates terminal) - Add window monitor to close duplicate main windows if created - Mark TermQAppDelegate as @mainactor for Swift 6 concurrency This fixes the blank terminal issue and multiple window spawning that occurred since v0.6.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
eyelock
force-pushed
the
fix/single-window-enforcement
branch
from
7e56d1a to
c511899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Multiple windows cause terminal views to appear blank because
NSViewcan only have one parent. When two windows display the same terminal, the view gets "stolen" from one window to another.This fixes the blank terminal issue and multiple window spawning that occurred since v0.6.0.
Test Plan
🤖 Generated with Claude Code