PR #3: Environment Tab Integration

[eyelock]

Summary

• Split KeyValueEditor into focused components
• Add proper error handling for secrets
• Fix encryption key status updates
• Add secret visibility toggle in Terminal Details

Changes

KeyValueEditor.swift:

• Split into KeyValueList (view) + KeyValueAddForm (add) + KeyValueEditor (deprecated wrapper)

SettingsEnvironmentView.swift:

• Use split components in separate sections
• Add error alerts (replaced try?)
• Fix encryption key status race condition

CardEditorEnvironmentTab.swift:

• Use split components
• Add secret visibility toggle for inherited globals
• Add error handling

Localization:

• Add section headers for better organization

🤖 Generated with Claude Code

[claude]

Code Review

I found 1 issue that requires attention:

❌ Hardcoded string should be localized

Files:

• Sources/TermQ/Views/CardEditorEnvironmentTab.swift:84
• Sources/TermQ/Views/SettingsEnvironmentView.swift:33

Issue:
The hardcoded English string "An unknown error occurred" should be added to the localization system to support all 40 languages in this project.

CLAUDE.md Reference:
As specified in commands/localization.md, all user-facing strings must be defined in Strings.swift and Localizable.strings.

Suggested fix:

1. Add a new key to Strings.swift:

extension Strings.Alert {
    static let unknownError = String(localized: "alert.error.unknown")
}

2. Add "alert.error.unknown" = "An unknown error occurred"; to en.lproj/Localizable.strings

3. Run /localization sync to propagate to all 40 language files

4. Replace both occurrences:

Text(errorMessage ?? Strings.Alert.unknownError)

Context:

• CardEditorEnvironmentTab.swift:82-86
• SettingsEnvironmentView.swift:31-35

---

Summary: All other changes look good. No bugs found. CLAUDE.md compliance verified except for the localization issue above.

[claude]

Code Review

Found 1 issue requiring attention:

Hardcoded UI strings should be localized

Locations:

• TermQ/Sources/TermQ/Views/CardEditorEnvironmentTab.swift

  Lines 81 to 86 in d0e69bf

  	.alert(Strings.Alert.error, isPresented: $showErrorAlert) {
  	Button(Strings.Common.ok) {}
  	} message: {
  	Text(errorMessage ?? "An unknown error occurred")
  	}
  	}

• TermQ/Sources/TermQ/Views/SettingsEnvironmentView.swift

  Lines 30 to 35 in d0e69bf

  	.alert(Strings.Alert.error, isPresented: $showErrorAlert) {
  	Button(Strings.Common.ok) {}
  	} message: {
  	Text(errorMessage ?? "An unknown error occurred")
  	}
  	}

The string "An unknown error occurred" is a user-facing error message that appears in alert dialogs but is not localized.

Why this matters:
Per implementation-checks.md:

If you modified UI strings or Swift files with UI: REQUIRED: Run localization validation

This project supports 40 languages and uses a comprehensive localization system. User-facing strings should use the Strings.* pattern instead of hardcoded literals.

Suggested fix:

// 1. Add to Localizable.strings:
"alert.unknown.error" = "An unknown error occurred";

// 2. Add to Strings.swift:
extension Strings.Alert {
    static let unknownError = NSLocalizedString("alert.unknown.error", comment: "Generic error message")
}

// 3. Replace both occurrences:
Text(errorMessage ?? Strings.Alert.unknownError)

Context:
Both files already use localized strings for the alert title (Strings.Alert.error) and button (Strings.Common.ok), making the hardcoded fallback message inconsistent with the established pattern.