PR #7: Final Polish - StatusIndicator & Settings View Extraction

[eyelock]

Overview

Final polish PR completing deferred work from PR #6 and fixing SwiftLint violations in SettingsView.swift.

Changes

1. StatusIndicator Applied to Global Settings ✅

• Applied StatusIndicator component to Global Settings > Tools tab
• Replaced manual HStack status displays with StatusIndicator calls
• Achieves consistency with Terminal Details editor (PR feat: add quick new terminal button to focused terminal toolbar #6)
• Result: Removed ~90 lines of duplicate status display code

2. Settings View Extraction ✅

Fixed critical SwiftLint violations in SettingsView.swift:

Before:

• File length: 528 lines (limit 500) ❌
• Type body length: 398 lines (limit 300) ❌

After:

• File length: 335 lines ✅
• Type body length: Under limit ✅

Extracted Views:

• SettingsGeneralView.swift - Terminal, Bin, Updates, Language, Uninstall, About sections
• SettingsDataSecurityView.swift - Security, Data Storage, Data Protection sections

Technical Implementation:

• Used Binding wrapper for defaultBackend (String ↔ TerminalBackend conversion)
• Maintained exact same functionality, no behavior changes
• All sections preserved with identical UI/UX

3. Component Documentation ✅

Added "Reusable UI Components" section to .claude/commands/code-style.md:

Documented Components:

• PathInputField - Path inputs with validation and file picker
• SharedToggle - Two-tier permission system toggles
• StatusIndicator - Feature/service status display with visual indicators
• LargeTextInput - Multi-line input with fixed height (prevents layout jumping)
• KeyValueEditor - Environment variables and tag management

Each component includes:

• When to use (use cases)
• Code examples
• Technical notes where relevant
• File location reference

Testing

Build & Tests

make check

• ✅ Build successful (zero errors)
• ✅ All 521 tests pass
• ✅ No SwiftLint warnings for modified files

Manual Testing

• ✅ Settings > General tab - All controls functional
• ✅ Settings > Data & Security tab - All controls functional
• ✅ Settings > Tools tab - StatusIndicator displays correctly
• ✅ No visual differences from before extraction
• ✅ All bindings work correctly

Files Modified

Modified

• Sources/TermQ/Views/SettingsView.swift - View extraction, reduced from 528 → 335 lines
• Sources/TermQ/Views/ToolsTabContent.swift - Applied StatusIndicator
• .claude/commands/code-style.md - Added component usage patterns

Created

• Sources/TermQ/Views/Settings/SettingsGeneralView.swift - 169 lines
• Sources/TermQ/Views/Settings/SettingsDataSecurityView.swift - 74 lines

Related

• Parent Plan: .claude/plans/settings-ui-improvements-implementation.md
• PR Plan: .claude/plans/2026-01-19-pr7-final-polish-documentation.md
• Previous PR: feat: improve terminal editor with Prompts tab and better components (PR #6/8) #74 (PR feat: add quick new terminal button to focused terminal toolbar #6 - Terminal Path & Toggles)
• Series: PR fix: add pin toggle to board view and fix terminal CWD switching #7 of 8 in Settings UI Improvements

Success Criteria

• ✅ StatusIndicator applied to Global Settings > Tools tab
• ✅ SettingsView.swift file length under 500 lines (now 335)
• ✅ SettingsView.swift type body length under 300 lines
• ✅ All extracted views maintain exact same functionality
• ✅ Component usage patterns documented in code-style.md
• ✅ All 521 tests pass
• ✅ Zero build errors
• ✅ Manual testing verified (all tabs work correctly)
• ✅ SettingsView.swift SwiftLint warnings eliminated

Next Steps

After this PR merges:

• PR feat: v0.3.0 improvements #8: Badge wrapping fixes (final PR in series)

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.