fix: Improve keyboard shortcuts and window management#84
Merged
Conversation
- Cmd+W now closes window (keeps app running, preserves sessions) - Cmd+Shift+W closes current tab (moved from Cmd+W) - Red X button shows confirmation dialog when terminals running - Cmd+Option+Z for toggle zoom (was Cmd+Shift+Z, avoiding Redo conflict) - Window close properly hides window without minimizing - Updated keyboard shortcuts documentation Fixes power user workflow with standard macOS shortcuts. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
The 'sign' target was removed in PR #83 and merged into the build process, but the 'debug' target still depended on it, causing: make: *** No rule to make target 'sign', needed by 'debug'. Stop. Fixed by updating debug to depend on 'build' instead. Caught by Claude Code bot review. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes power user keyboard shortcuts to follow standard macOS conventions and improve window management during Phase 1 testing.
Changes
Keyboard Shortcuts
Window Management
orderOut(nil)Documentation
Docs/Help/keyboard-shortcuts.mdwith:Testing
All shortcuts tested and working:
Technical Details
windowShouldClosedelegate method handles confirmationorderOut(nil)properly hides window without minimizing🤖 Generated with Claude Code