docs: Document branch protection and Claude Code review workflow#91
Merged
Conversation
eyelock
force-pushed
the
make-claude-review-required
branch
from
0c979e2 to
887ec8f
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Add documentation for: - Required CI checks for main branch (Build, Test, Lint, Format Check) - Claude Code review workflow (currently informational, not blocking) The claude-review workflow posts helpful comments about localization issues and code quality but doesn't currently fail when issues are found. Making it a required blocking check requires updating the workflow to exit with an error code when review comments are posted. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
eyelock
force-pushed
the
make-claude-review-required
branch
from
887ec8f to
28b3ec5
Compare
eyelock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the current branch protection setup and Claude Code review workflow.
Changes
.github/BRANCH_PROTECTION.mdDocumentation Covers
Required Checks (blocking):
Informational Checks (non-blocking):
Future Work
To make Claude review blocking, the workflow needs to be updated to:
This would ensure localization issues (like those in PR #90) block merges automatically.
Addresses feedback from PR #90 where Claude review caught localization issues.