You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
on-sell commands not executing for item-type: COMMAND items — sell() no longer checks or removes physical items from the player's inventory when the item's delivery type is COMMAND. Previously the transaction exited early with "insufficient items" because the player had no material to hand over, preventing sell commands from running at all.
on-sell execute-as overridden by on-buy execute-as — ShopPricingManager now tracks execute-as independently for the on-buy and on-sell blocks. Previously a single shared flag meant that setting on-buy: execute-as: player would silently override on-sell: execute-as: console, causing sell commands to run as the player instead of the console.
Added
Code coverage reporting — JaCoCo is now configured in the Maven build (jacoco-maven-plugin 0.8.12). Coverage reports (jacoco.xml) are generated on every mvn test run and uploaded to Codecov by the CI workflow for both unit-test and feature-test jobs.