[FEATURE] Add command "init" to configure platform install for legacy bridge usage by andrerom · Pull Request #147 · ezsystems/LegacyBridge

andrerom · 2018-04-10T09:34:06Z

In order to simplify upgrades from pure legacy installs, this command is meant to be used like this to simplify install / upgrades (in comparison to todays INSTALL.md, which does not cover upgrades, and is a bit more manual still):

Enable bundle(s)
(Optional) Edit config for legacy routes, & enable legacy mode for backend
Install legacy bridge
Run init which will:
- Generate all legacy related folders, and tell you which one is which and where to copy your files from eZ Publish
- Adjust composer.json as current described in INSTALL doc automatically ?
  - Add the composer legacy post-*-scripts
  - Enable EzPublishLegacyBundle
  - Add legacy routes
  - ~~Optional: Enable legacy_mode for your backoffice siteaccess~~
  - ~~Optional: add security rules for the Setup Wizard~~
  - ~~Optional: Ask user to install recommended extensions / bundles (search ext, richtext ext, ..)~~
  - Instruct user to run composer run-script post-update-cmd once things have been moved into folders, or maybe rather composer legacy-scripts
Update INSTALL doc to reflect usage of this command.

andrerom · 2018-05-13T13:00:50Z

@emodric what do you think?

ref:
bin/console ezpublish:legacy:init --help

"Inits folders you can use when migrating from eZ Publish install to eZ Platform with Legacy Bridge"

emodric

This looks good (with one minor remark about spelling). What is missing is some docs on the intended usage workflow (init and then symlink?).

emodric · 2018-05-14T12:26:34Z

+                <<<EOT
+The command <info>%command.name%</info> creates the following folders for migration usage:
+- src/AppBundle/ezpublish_legacy => Optionaly for extensions you want to version in your project source (as opposed to install using composer)
+- src/legacy_files/design  => Optionally for cusotm designs not already made part of an extension


andrerom · 2018-05-14T13:12:46Z

@emodric PR description updated to reflect better the overall workflow I'm suggesting here.

This might be something @vidarl, @crevillo, @joekepley and @peterkeung might want to give input on as well here.

vidarl · 2018-10-25T09:52:42Z

Implemented "Adjust composer.json as current described in INSTALL doc automatically"...

Sign in to view

+            $updateComposerJson = true;
+        } elseif (!in_array('@legacy-scripts', $composerJson['scripts']['symfony-scripts'])) {
+            $symfonyScripts = $composerJson['scripts']['symfony-scripts'];
+            $offset = array_search('@php bin/console assetic:dump', $symfonyScripts);


andrerom · 2018-10-26T08:59:54Z

+legacy install:
+- <info>ezpublish:legacy:symlink</info>
+- <info>ezpublish:legacybundles:install_extensions</info>
+- <info>ezpublish:legacy:assets_install</info>


these can now be changed to composer legacy-scripts

Sign in to view

+        }
+
+        if (!array_key_exists('symfony-scripts', $composerJson['scripts'])) {
+            $composerJson['scripts']['symfony-scripts'] = ['@legacy-scripts'];


Move creation of intial structure for migration to own command to also cover needs for creating extension folder.

…ions

…poser.json

…eldtype package

andrerom · 2019-02-18T15:39:11Z

@emodric / @vidarl Should be ready for review now, this can be expanded later with asking user to install recommended bundles / extensions as well.

Co-Authored-By: andrerom <andre.romcke@gmail.com>

emodric · 2019-02-21T08:24:25Z

I'd like to see manual install instructions preserved in a separate file, as I don't like to rely on scripted installations 100%.

Otherwise, looks good.

andrerom · 2019-02-26T09:09:07Z

@emodric Better?

Update: Got 👍 on slack

andrerom requested review from emodric and vidarl April 10, 2018 09:34

andrerom changed the base branch from master to 1.4 April 10, 2018 09:34

andrerom force-pushed the also_symlink_extension_folder branch from c08267e to ab43a22 Compare April 10, 2018 10:17

This comment has been minimized.

Sign in to view

andrerom force-pushed the also_symlink_extension_folder branch from ab43a22 to 0b06e0d Compare April 23, 2018 21:49

This comment has been minimized.

Sign in to view

andrerom force-pushed the also_symlink_extension_folder branch from 0b06e0d to 103870d Compare April 23, 2018 22:01

ezsystems deleted a comment from ezrobot Apr 23, 2018

emodric approved these changes May 14, 2018

View reviewed changes

andrerom changed the title ~~[ezpublish:legacy:symlink] Also support symlinking extension folders~~ [WIP] Add command "init" to creating folder structure legacy bridge usage May 14, 2018

andrerom changed the title ~~[WIP] Add command "init" to creating folder structure legacy bridge usage~~ [RFC] Add command "init" to creating folder structure legacy bridge usage May 14, 2018

andrerom force-pushed the also_symlink_extension_folder branch from e348452 to 2bfe4ce Compare June 29, 2018 10:16

andrerom changed the title ~~[RFC] Add command "init" to creating folder structure legacy bridge usage~~ [WIP] Add command "init" to creating folder structure legacy bridge usage Jun 29, 2018

ezsystems deleted a comment from ezrobot Oct 25, 2018

andrerom commented Oct 26, 2018

View reviewed changes

Comment thread bundle/Command/LegacyInitCommand.php

}

if (!array_key_exists('symfony-scripts', $composerJson['scripts'])) {

$composerJson['scripts']['symfony-scripts'] = ['@legacy-scripts'];

This comment was marked as resolved.

Sign in to view

vidarl force-pushed the also_symlink_extension_folder branch from 89fcfce to 217b792 Compare October 29, 2018 13:02

ezsystems deleted a comment from ezrobot Oct 29, 2018

andrerom changed the base branch from 1.4 to 1.5 February 18, 2019 13:01

andrerom force-pushed the also_symlink_extension_folder branch from 9516554 to 1280828 Compare February 18, 2019 13:02

This comment has been minimized.

Sign in to view

andrerom force-pushed the also_symlink_extension_folder branch 2 times, most recently from 7c18f2e to f1b2798 Compare February 18, 2019 13:55

André R and others added 6 commits February 18, 2019 16:15

Create new command for initilizing folder structure for migrations

d0589ad

Move creation of intial structure for migration to own command to also cover needs for creating extension folder.

fixup! Create new command for initilizing folder structure for migrat…

82426c0

…ions

Fixed so that ezpublish:legacy:init script adds legacy scripts to com…

f21e45d

…poser.json

Update LegacyInitCommand.php

c9ea9a7

Update install doc

25a5162

[composer] align with 2.x and require ezsystems/ezplatform-xmltext-fi…

01f9893

…eldtype package

andrerom force-pushed the also_symlink_extension_folder branch from 6e5b264 to 01f9893 Compare February 18, 2019 15:18

andrerom changed the title ~~[WIP] Add command "init" to creating folder structure legacy bridge usage~~ [FEATURE] Add command "init" to configure platform install for legacy bridge usage Feb 18, 2019

andrerom requested a review from glye February 18, 2019 15:38

glye approved these changes Feb 19, 2019

View reviewed changes

glye and others added 5 commits February 19, 2019 20:34

Update bundle/Command/LegacyConfigurationCommand.php

b2de33f

Co-Authored-By: andrerom <andre.romcke@gmail.com>

Update bundle/Command/LegacyInitCommand.php

a94d9b8

Co-Authored-By: andrerom <andre.romcke@gmail.com>

Update bundle/Command/LegacyInitCommand.php

db8944f

Co-Authored-By: andrerom <andre.romcke@gmail.com>

Update INSTALL.md

5dc2a42

Co-Authored-By: andrerom <andre.romcke@gmail.com>

Remove teswt code

ee052c0

Add INSTALL-MANUALLY.md

951bfa4

andrerom merged commit 3e3fc7c into 1.5 Feb 26, 2019

andrerom deleted the also_symlink_extension_folder branch February 26, 2019 09:25

Conversation

andrerom commented Apr 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrerom commented May 13, 2018

Uh oh!

emodric left a comment

Choose a reason for hiding this comment

Uh oh!

emodric May 14, 2018

Choose a reason for hiding this comment

Uh oh!

andrerom commented May 14, 2018

Uh oh!

vidarl commented Oct 25, 2018

Uh oh!

This comment was marked as resolved.

Uh oh!

andrerom Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment has been minimized.

andrerom commented Feb 18, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emodric commented Feb 21, 2019

Uh oh!

andrerom commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

andrerom commented Apr 10, 2018 •

edited

Loading

andrerom commented Feb 26, 2019 •

edited

Loading