[Optimization] Skip loading user and path if not needed#171
Merged
Conversation
emodric
reviewed
May 3, 2019
Collaborator
emodric
left a comment
emodric
left a comment
There was a problem hiding this comment.
Since I'm on vacation, I'll have to test these, not just visual, when I come back, next week :)
Contributor
Author
|
@emodric Can you review this despite the Travis PHP 5.6 proc_open() failure? |
emodric
approved these changes
May 14, 2019
Collaborator
emodric
left a comment
emodric
left a comment
There was a problem hiding this comment.
Seems okay, although, I only tested on 2.x by manually merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some optimizations to reduce default Repo lookups by bridge from 11 to 3 cache lookups , this also avoids the serialization and mapping of these objects to API objects and logic around that.