Skip to content

Remove visibility change on global helper core service override.#175

Merged
andrerom merged 2 commits into
ezsystems:masterfrom
xserna:master
Dec 17, 2019
Merged

Remove visibility change on global helper core service override.#175
andrerom merged 2 commits into
ezsystems:masterfrom
xserna:master

Conversation

@xserna
Copy link
Copy Markdown
Contributor

@xserna xserna commented Dec 3, 2019

PR coming from #126 (comment)

@andrerom andrerom requested a review from emodric December 3, 2019 12:31
@emodric
Copy link
Copy Markdown
Collaborator

emodric commented Dec 3, 2019

Can you use public: true to mark it specifically as public, instead of relying on the default Symfony behaviour (and to avoid the deprecation message)?

You can also leave a comment why it is needed to be public.

@andrerom
Copy link
Copy Markdown
Contributor

@emodric Maybe you can use suggest feature for what you had in mind?

Comment thread bundle/Resources/config/templating.yml
@xserna xserna requested review from andrerom and emodric December 17, 2019 15:24
@andrerom andrerom merged commit d266caa into ezsystems:master Dec 17, 2019
@andrerom
Copy link
Copy Markdown
Contributor

Thanks @xserna 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants