Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Fix EZP-27265: Missing translation for notification when user try to …#850

Merged
andrerom merged 1 commit intoezsystems:1.7from
adamwojs:Fix-EZP-27265_missing_translation_for_form_validation_error
May 9, 2017
Merged

Fix EZP-27265: Missing translation for notification when user try to …#850
andrerom merged 1 commit intoezsystems:1.7from
adamwojs:Fix-EZP-27265_missing_translation_for_form_validation_error

Conversation

@adamwojs
Copy link
Member

JIRA issue: https://jira.ez.no/browse/EZP-27265

Description

This PR fix missing english translation for notification displayed when user try to submit invalid data in content type editor.

Steps to reproduce

  1. On the admin UI go to content type edit form
  2. Change identifier of any field to something incorrect e.g. foo-1
  3. Save changes
  4. Message displayed on the bottom contains form.validation_error instead of human readable text - see attached screenshot

Tests

Manual

<body>
<trans-unit id="07ec12f4689ee90ade282338b25b99b9677b0d08" resname="form.validation_error">
<source>form.validation_error</source>
<target>form.validation_error</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also update the <source>. Here is an example on another file: https://github.com/ezsystems/PlatformUIBundle/blob/1.7/Resources/translations/fieldview.en.xlf#L10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;-)

Copy link
Contributor

@yannickroger yannickroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with commits squashed into one.

@adamwojs adamwojs force-pushed the Fix-EZP-27265_missing_translation_for_form_validation_error branch from ce3e920 to e4d5ba8 Compare April 24, 2017 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants