EZP-30358: HTTP Cache purge when ContentService\{Hide,Reveal}ContentSignal is emitted#81
Conversation
adamwojs
requested review from
ViniTou,
alongosz,
andrerom,
mikadamczyk and
pawbuj
adamwojs
changed the title
composer.json
Outdated
| ], | ||
| "require": { | ||
| "ezsystems/ezpublish-kernel": "^6.13.4@dev || ^7.3@dev", | ||
| "ezsystems/ezpublish-kernel": "^6.13.4@dev || ^7.5@dev", |
There was a problem hiding this comment.
Will it work for 2.4 branch? Ezplatform 2.4 uses both:
"ezsystems/ezpublish-kernel": "~7.4.0@dev",
"ezsystems/ezplatform-http-cache": "~0.9.0@dev",
(https://github.com/ezsystems/ezplatform/blob/2.4/composer.json#L36)
which will clash with this requirement if I'm not mistaken
There was a problem hiding this comment.
Good catch Marek. This code can not crash 2.4 version. Is this doable?
There was a problem hiding this comment.
Afaik it won't crash, if it does we also have same issue on 1.13.
So we can change to ^7.4@dev, right @adamwojs ?
There was a problem hiding this comment.
Actually, it should work fine without composer.json modification (signal is not emitted => slot will not be executed). We will check this during QA.
There was a problem hiding this comment.
Yeah, it's only solr having issues with this due to the use of abstract search slots, which is in retrospective not a good idea.
…ontentSignal is emited
…ontentSignal is emited
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
We checked with Marek that this resolves the issue on Varnish and filesystem cache. 👍
|
@micszo Great news, can we merge it? |
|
@adamwojs did you want to fix CI before? |
|
Travis failure is basically same 2.4 and 1.13 will experience so indeed we need to get that green :) |
…ontentSignal is emited
|
Well done! |
8 participants
Description
Implementation of HTTP cache purge when
ContentService\HideContentSignal/ContentService\RevealContentSignalis emitted.