Skip to content

Add support for PHP 7.4#230

Merged
ezyang merged 3 commits into
ezyang:masterfrom
snapshotpl:master
Sep 12, 2019
Merged

Add support for PHP 7.4#230
ezyang merged 3 commits into
ezyang:masterfrom
snapshotpl:master

Conversation

@snapshotpl
Copy link
Copy Markdown
Contributor

No description provided.

@snapshotpl
Copy link
Copy Markdown
Contributor Author

Strange: all tests pass, but in my project I get error. Missing test case?

Array and string offset access syntax with curly braces is deprecated

/var/www/vendor/ezyang/htmlpurifier/library/HTMLPurifier/Encoder.php:162
/var/www/vendor/ezyang/htmlpurifier/library/HTMLPurifier.php:177
...

@snapshotpl
Copy link
Copy Markdown
Contributor Author

I see it's fixed in master. Great. Anyway, test for 7.4 are ok :-)

@snapshotpl snapshotpl changed the title Add php7.4 Add support for PHP 7.4 Sep 11, 2019
@ezyang ezyang merged commit c6ca293 into ezyang:master Sep 12, 2019
@snapshotpl
Copy link
Copy Markdown
Contributor Author

@ezyang is it possible to release this changes?

@emodric
Copy link
Copy Markdown
Contributor

emodric commented Sep 26, 2019

@ezyang Hi. I'd also like to see a new release with PHP 7.4 support.

PHP 7.4 is in RC phase and we would like for our builds to be green.

@ezyang
Copy link
Copy Markdown
Owner

ezyang commented Sep 26, 2019

okey maybe this weekend

@emodric
Copy link
Copy Markdown
Contributor

emodric commented Sep 30, 2019

Hi @ezyang. Any news on the release?

@sebastiaanluca
Copy link
Copy Markdown

PHP 7.4 has been released, any news on releasing support for it? Currently can't upgrade our app. Thanks!

@ezyang
Copy link
Copy Markdown
Owner

ezyang commented Dec 12, 2019

Yes, 4.12.0 is released and has the compat changes.

ezyang pushed a commit that referenced this pull request Jul 6, 2020
Corresponding PRs (#230, #242) are about PHP 7.4 and PHP 6.4 has never
existed 🙂.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants