refactor: make signin format same with SuccessResponseDTO #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
============================================
+ Coverage 84.63% 84.69% +0.06%
Complexity 152 152
============================================
Files 42 42
Lines 729 732 +3
Branches 31 31
============================================
+ Hits 617 620 +3
Misses 91 91
Partials 21 21
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR?
SigninResponse Data Type 준수 #117Key Changes
Filter단 에서 request처리가 끝나 ResponseAdvice에 적용을을 못받는 엔드포인트에 대해
SuccessResponseDTO 형식을 수동으로 맞추어줌
Test Checklist