Skip to content

Conversation

@ayakut16
Copy link
Contributor

@ayakut16 ayakut16 commented Apr 8, 2025

Description

Not being able to use spaces or different usage of call vs call <tool_name> in shell causes confusion. (#8 #25)

This PR fixes and add tests for the following use cases:

  1. <tool_name>
  2. call <tool_name>
  3. <tool_name> <params>
  4. call <tool_name> <params>
  5. <tool_name> '<params>'
  6. call <tool_name> '<params>'
  7. <tool_name> --params <params>
  8. call <tool_name> --params <params>
  9. <tool_name> --params '<params>'
  10. call <tool_name> --params '<params>'

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit tests
  • Local run of changes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@f f merged commit 93158a5 into f:master Apr 8, 2025
2 checks passed
@ayakut16 ayakut16 deleted the fix/shell-parser branch April 11, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants