Skip to content

fix: voice tracking highlight and mic stall bugs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f merged 1 commit into from
May 8, 2026
Merged

fix: voice tracking highlight and mic stall bugs #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 36 additions & 31 deletions Textream/Textream/NotchOverlayController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,21 +374,27 @@ class NotchOverlayController: NSObject {
}

func dismiss() {
guard !isDismissing else { return }
isDismissing = true

// Trigger the shrink animation
speechRecognizer.shouldDismiss = true
speechRecognizer.forceStop()

// Wait for animation, then remove panel
DispatchQueue.main.asyncAfter(deadline: .now() + 0.4) { [weak self] in
self?.stopMouseTracking()
self?.stopCursorTracking()
self?.removeStopButton()
self?.removeEscMonitor()
self?.panel?.orderOut(nil)
self?.panel = nil
self?.frameTracker = nil
self?.speechRecognizer.shouldDismiss = false
self?.onComplete?()
guard let self else { return }
self.stopMouseTracking()
self.stopCursorTracking()
self.removeStopButton()
self.removeEscMonitor()
self.cancellables.removeAll()
self.panel?.orderOut(nil)
self.panel = nil
self.frameTracker = nil
self.speechRecognizer.shouldDismiss = false
self.isDismissing = false
self.onComplete?()
}
}

Expand Down Expand Up @@ -424,41 +430,40 @@ class NotchOverlayController: NSObject {
}

private func observeDismiss() {
// Poll for shouldAdvancePage (next page requested from overlay)
// Single timer polls all conditions instead of two separate timers
Timer.publish(every: 0.1, on: .main, in: .common)
.autoconnect()
.sink { [weak self] _ in
guard let self else { return }

// Check for page advance
if self.speechRecognizer.shouldAdvancePage {
self.speechRecognizer.shouldAdvancePage = false
self.onNextPage?()
}
// Poll for page jump from page picker

// Check for page jump from page picker
if let targetIndex = self.overlayContent.jumpToPageIndex {
self.overlayContent.jumpToPageIndex = nil
TextreamService.shared.jumpToPage(index: targetIndex)
}
}
.store(in: &cancellables)

// Poll for shouldDismiss becoming true (from view setting it on completion)
Timer.publish(every: 0.1, on: .main, in: .common)
.autoconnect()
.sink { [weak self] _ in
guard let self, self.speechRecognizer.shouldDismiss, !self.isDismissing else { return }
self.isDismissing = true
// Wait for shrink animation, then cleanup
DispatchQueue.main.asyncAfter(deadline: .now() + 0.4) {
self.stopMouseTracking()
self.stopCursorTracking()
self.removeStopButton()
self.removeEscMonitor()
self.cancellables.removeAll()
self.panel?.orderOut(nil)
self.panel = nil
self.frameTracker = nil
self.speechRecognizer.shouldDismiss = false
self.onComplete?()
// Check for dismiss
if self.speechRecognizer.shouldDismiss, !self.isDismissing {
self.isDismissing = true
DispatchQueue.main.asyncAfter(deadline: .now() + 0.4) { [weak self] in
guard let self else { return }
self.stopMouseTracking()
self.stopCursorTracking()
self.removeStopButton()
self.removeEscMonitor()
self.cancellables.removeAll()
self.panel?.orderOut(nil)
self.panel = nil
self.frameTracker = nil
self.speechRecognizer.shouldDismiss = false
self.onComplete?()
}
}
}
.store(in: &cancellables)
Expand Down
Loading