Skip to content

Conversation

@sky-code
Copy link
Collaborator

@sky-code sky-code commented Jun 1, 2018

wrapLoading helper function for easy integration of vuex-loading in vue component methods

rename v-loading slot spinner to loading - much more clear what this slot mean

@sky-code sky-code changed the title add wrapLoading helper function, fix examples, fix logging format add wrapLoading helper function, fix examples, fix logging format, rename spinner to loading Jun 1, 2018
@Koc
Copy link
Contributor

Koc commented Jun 5, 2018

@sky-code nice addition. Can we use this function as decorator? ref #15

@f
Copy link
Owner

f commented Jun 5, 2018

Wow this is really a thing, seems neat. I agree with @Koc if that can be a decorator.

@f
Copy link
Owner

f commented Jun 5, 2018

I'm going to merge it but won't publish a release for now.

@f f merged commit bc64f86 into f:master Jun 5, 2018
@f
Copy link
Owner

f commented Jun 5, 2018

Another use case, maybe we can an extend API for mapActions mappings.

...mapLoadingActions('somestore', [
  someRequest: 'something loading',
]);

...

this.someRequest(); // will start loader 'something loading'

would be awesome.

If we can make it, we can drop store helpers and move to this since loading is an UI issue and managing it in stores is kinda not-cool.

@f
Copy link
Owner

f commented Jun 5, 2018

@sky-code And I made you a collaborator of this package since your work is awesome for this project, thank you!

@sky-code
Copy link
Collaborator Author

sky-code commented Jun 5, 2018

@f

I'm going to merge it but won't publish a release for now.

why not release?
v0.4.0 with new feature will be good

@f
Copy link
Owner

f commented Jun 5, 2018

@sky-code Ok then, let's do it tonight.

But this library feels me some rewrite for v1.0, I'm not very confident with bundled loaders (I think we should remove them and put just one default spinner) and also not confident with startLoader and endLoader helpers. Those parts needs to be better. Also we can create mapLoadingActions helper for Vuex bindings which would make the library cleaner.

@sky-code
Copy link
Collaborator Author

sky-code commented Jun 5, 2018

Agree with bundled loaders.
I am not very good in vue internals so I dont know how to Implement mapLoadingActions.

@Koc
Copy link
Contributor

Koc commented Jun 5, 2018

rename v-loading slot spinner to loading - much more clear what this slot mean

only one wish: can you add changelog files, please? it is too hard to upgrade between releases.

@sky-code
Copy link
Collaborator Author

sky-code commented Jun 5, 2018

@f
Copy link
Owner

f commented Jun 6, 2018

0.4.0 is now published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants