-
-
Notifications
You must be signed in to change notification settings - Fork 101
add wrapLoading helper function, fix examples, fix logging format, rename spinner to loading #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wow this is really a thing, seems neat. I agree with @Koc if that can be a decorator. |
|
I'm going to merge it but won't publish a release for now. |
|
Another use case, maybe we can an extend API for ...mapLoadingActions('somestore', [
someRequest: 'something loading',
]);
...
this.someRequest(); // will start loader 'something loading'would be awesome. If we can make it, we can drop store helpers and move to this since loading is an UI issue and managing it in stores is kinda not-cool. |
|
@sky-code And I made you a collaborator of this package since your work is awesome for this project, thank you! |
why not release? |
|
@sky-code Ok then, let's do it tonight. But this library feels me some rewrite for v1.0, I'm not very confident with bundled loaders (I think we should remove them and put just one default spinner) and also not confident with |
|
Agree with bundled loaders. |
only one wish: can you add changelog files, please? it is too hard to upgrade between releases. |
|
0.4.0 is now published. |
wrapLoading helper function for easy integration of vuex-loading in vue component methods
rename
v-loadingslotspinnertoloading- much more clear what this slot mean