Skip to content

Commit 7b8b469

Browse files
author
tuomaspelkonen
committed
Changed the postponed unit tests warning message
Summary: Postponed unit tests are not unit tests with problems. The results just haven't arrived yet. Test Plan: Tested accepting a diff with unit status 1, 3, 5 (ok, errors, postponed) Reviewers: jungejason, epriestley Reviewed By: epriestley CC: aran, epriestley, tuomaspelkonen Differential Revision: 969
1 parent 9155369 commit 7b8b469

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/applications/differential/view/addcomment/DifferentialAddCommentView.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,16 @@ public function render() {
158158
DifferentialUnitStatus::UNIT_SKIP => 'Unit Tests Skipped',
159159
DifferentialUnitStatus::UNIT_POSTPONED => 'Unit Tests Postponed'
160160
);
161-
$content =
162-
"<p>This diff has Unit Test Problems. Make sure you are OK with them ".
163-
"before you accept this diff.</p>";
161+
if ($diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) {
162+
$content =
163+
"<p>This diff has postponed unit tests. The results should be ".
164+
"coming in soon. You should probably wait for them before accepting ".
165+
"this diff.</p>";
166+
} else {
167+
$content =
168+
"<p>This diff has Unit Test Problems. Make sure you are OK with ".
169+
"them before you accept this diff.</p>";
170+
}
164171
$unit_warning = $this->generateWarningView(
165172
$diff->getUnitStatus(),
166173
$titles,

0 commit comments

Comments
 (0)