Revive essential commit details

Summary: Deleted by D3977.

Test Plan:
  ./reparse.php --message

Reviewers: epriestley, edward

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4090

Author: vrana

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -370,11 +370,8 @@ private function getCommitProperties(
     }
 
     $reviewer_phid = $data->getCommitDetail('reviewerPHID');
-    $reviewer_name = $data->getCommitDetail('reviewerName');
     if ($reviewer_phid) {
       $props['Reviewer'] = $handles[$reviewer_phid]->renderLink();
-    } else if ($reviewer_name) {
-      $props['Reviewer'] = phutil_escape_html($reviewer_name);
     }
 
     $committer = $data->getCommitDetail('committer');

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

@@ -34,6 +34,34 @@ final protected function updateCommitData($author, $message,
       $data->getCommitDetail('authorPHID'));
     $data->setCommitDetail('authorPHID', $author_phid);
 
+    $user = new PhabricatorUser();
+    if ($author_phid) {
+      $user = $user->loadOneWhere(
+        'phid = %s',
+        $author_phid);
+    }
+
+    $call = new ConduitCall(
+      'differential.parsecommitmessage',
+      array(
+        'corpus' => $message,
+        'partial' => true,
+      ));
+    $call->setUser($user);
+    $result = $call->execute();
+
+    $field_values = $result['fields'];
+
+    if (!empty($field_values['reviewedByPHIDs'])) {
+      $data->setCommitDetail(
+        'reviewerPHID',
+        reset($field_values['reviewedByPHIDs']));
+    }
+
+    $data->setCommitDetail(
+      'differential.revisionID',
+      idx($field_values, 'revisionID'));
+
     $committer_phid = $this->lookupUser(
       $commit,
       $data->getCommitDetail('committer'),
@@ -81,6 +109,10 @@ final protected function updateCommitData($author, $message,
 
       $revision = id(new DifferentialRevision())->load($revision_id);
       if ($revision) {
+        $data->setCommitDetail(
+          'differential.revisionPHID',
+          $revision->getPHID());
+
         $revision->loadRelationships();
         queryfx(
           $conn_w,
@@ -150,22 +182,7 @@ final protected function updateCommitData($author, $message,
       $lock->unlock();
     }
 
-    if ($should_autoclose && $author_phid) {
-      $user = id(new PhabricatorUser())->loadOneWhere(
-        'phid = %s',
-        $author_phid);
-
-      $call = new ConduitCall(
-        'differential.parsecommitmessage',
-        array(
-          'corpus' => $message,
-          'partial' => true,
-        ));
-      $call->setUser($user);
-      $result = $call->execute();
-
-      $field_values = $result['fields'];
-
+    if ($should_autoclose) {
       $fields = DifferentialFieldSelector::newSelector()
         ->getFieldSpecifications();
       foreach ($fields as $key => $field) {