BOLT12 fixes#2
Open
m0wer wants to merge 2 commits into
Open
Conversation
The LRU cache for processed onions keyed entries on onion_hash + payment_hash + is_trampoline only. With route blinding a receiver may advertise multiple blinded paths for the same payment; two incoming HTLCs sharing onion_hash and payment_hash but using different path_key bytes would otherwise be served the same cached result. Including path_key in the key removes the ambiguity. Also drops a commented-out debug line from the bolt12 regtest case.
UpdateAddHtlc.to_json now produces a 6-tuple (with the trailing 'path_key' field) instead of the previous 5-tuple. The new code reads either shape, but older electrum versions call from_tuple(*tuple) positionally and would raise TypeError on a 6-tuple entry. Bumping FINAL_SEED_VERSION ensures older clients refuse to open wallets that may now contain blinded HTLC entries, rather than failing mid-deserialization with an unclear error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the two fixes that still apply from accumulator#3 The others had been addressed already!