-
Notifications
You must be signed in to change notification settings - Fork 59
fix: make fontSize optional #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Assistant Lite bot ✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
|
@TheAlexLichter thanks for the fix! |
I haven't got a chance to review this PR. But I'm also open to make it an optional property. |
|
@rokotyan Given this example in the docs (and others) not adding explicit unovis/packages/website/docs/auxiliary/Annotations.mdx Lines 102 to 116 in 79f45dd
And that there are defaults in unovis/packages/ts/src/styles/index.ts Line 13 in 79f45dd
|
|
@TheAlexLichter I see. It's optional only for the Annotations component, so the type should be this:
|
|
Thanks for bringing up this inconsistency! |
|
@rokotyan Good point! Updated my PR to reflect that! |
|
Thanks! |
|
@TheAlexLichter could you please take a look at this: https://github.com/f5/unovis/actions/runs/14013488915/job/39393838730?pr=542? Thanks |
|
I've checked this again, and found that merging with default happens here. So the original idea of making Maybe it's worth renaming |
|
Fixed! |


According to the docs,
fontSizeis an optional property. This should be reflected in the types as well.