Conversation
- Remove confirmation when creating a new entrylist - Only allow upload of a single entrylist or result file - Improve variable naming and distinction between session and results
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to create entrylists directly from session results, refactors the UI for better workflow organization, and improves code robustness. The main addition is a new "Create from session" feature that generates an entrylist based on uploaded or selected session data, complementing the existing functionality to update an existing entrylist from session results.
Key Changes:
- Added
createFromSessionmethod to generate new entrylists from session results with automatic driver filtering and entry creation - Refactored UI to distinguish between creating new entrylists and loading session results into existing ones, with dedicated dialogs for each workflow
- Implemented custom
equalsandhashCodemethods forAccDriverto enable proper map-based driver tracking
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| EntrylistEditorView.java | Added "Create from session" button and dialog, refactored file upload limits, renamed methods/dialogs for clarity, and reorganized UI components |
| EntrylistService.java | Implemented createFromSession method to generate entrylists from session data, including driver filtering logic |
| AccTeam.java | Made getDriverByIndex null-safe to prevent NPE when drivers list is null |
| AccDriver.java | Added equals and hashCode methods based on playerId for use as map keys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
simdesk-web/src/main/java/de/sustineo/simdesk/views/EntrylistEditorView.java
Outdated
Show resolved
Hide resolved
simdesk-web/src/main/java/de/sustineo/simdesk/entities/json/kunos/acc/AccDriver.java
Show resolved
Hide resolved
simdesk-web/src/main/java/de/sustineo/simdesk/services/entrylist/EntrylistService.java
Outdated
Show resolved
Hide resolved
…fety - Improvements to null-safety - Enhance comments
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request introduces significant improvements to the entrylist editor, focusing on enhancing session result integration, streamlining entrylist creation, and improving robustness. The changes include a new workflow for creating entrylists from session results, better handling of file uploads, and some refactoring for clarity and maintainability.
Entrylist Creation & Session Integration
createFromSessionDialog) and supporting UI components such as the "Create from session" button and session upload handling. This allows users to generate entrylists based on uploaded or selected session data, improving usability for race organizers. [1] [2] [3]File Upload Improvements
UI & Dialog Refactoring
Robustness & Validation
NullPointerException.Code Quality & Equality Logic
equalsandhashCodemethods forAccDriver, ensuring correct behavior when using drivers as keys in maps or sets, which is essential for tracking laps and session associations. [1] [2]