Add UTF-16 BOM support for Vaadin file uploads#261
Merged
Conversation
Co-authored-by: fabieu <43068791+fabieu@users.noreply.github.com>
Co-authored-by: fabieu <43068791+fabieu@users.noreply.github.com>
Co-authored-by: fabieu <43068791+fabieu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for UTF-16 BOM in file uploads
Add UTF-16 BOM support for Vaadin file uploads
Nov 5, 2025
- Enforce formatting
- Changed detection algorithm in EncodingUtils - Update package for EncodingUtils
fabieu
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some data providers encode files in UTF-16 with BOM rather than UTF-8, causing upload failures when parsing JSON data.
Changes
New
EncodingUtilsutility: Detects and handles UTF-8, UTF-16LE, UTF-16BE with or without BOMUpdated upload handlers: Replace
new String(data)withEncodingUtils.bytesToString(data)BopEditorView,BopManagementView,EntrylistEditorViewExample
The utility defaults to UTF-8 when no BOM is present, maintaining backward compatibility. Test coverage includes all encoding combinations with and without BOMs.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.