Remove live timing feature and associated configurations#264
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the live timing feature from SimDesk due to implementation complexity and project overhead. The removal encompasses the complete deletion of the desktop client module, all live timing-related backend services, views, entities, and configurations.
- Complete removal of the
simdesk-desktopmodule including JavaFX client application - Deletion of live timing backend services, controllers, and WebSocket infrastructure
- Removal of dashboard-related views, forms, and database entities
- Database migrations to drop the dashboard table
- Configuration updates removing live timing profile from run configurations
Reviewed Changes
Copilot reviewed 49 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| simdesk-web/build.gradle | Removed WebSocket starter dependency |
| simdesk-web/src/main/java/de/sustineo/simdesk/configuration/ProfileManager.java | Removed live timing profile constant and helper method |
| simdesk-web/src/main/java/de/sustineo/simdesk/configuration/WebSocketConfiguration.java | Deleted WebSocket and STOMP configuration class |
| simdesk-web/src/main/java/de/sustineo/simdesk/controller/LiveTimingController.java | Deleted live timing message controller |
| simdesk-web/src/main/java/de/sustineo/simdesk/entities/livetiming/*.java | Deleted all live timing entity classes (Dashboard, CarInfo, SessionInfo, etc.) |
| simdesk-web/src/main/java/de/sustineo/simdesk/messaging/ApiKeyAuthenticationInterceptor.java | Deleted WebSocket authentication interceptor |
| simdesk-web/src/main/java/de/sustineo/simdesk/mybatis/mapper/DashboardMapper.java | Deleted dashboard database mapper |
| simdesk-web/src/main/java/de/sustineo/simdesk/services/MenuService.java | Removed dashboard menu entry |
| simdesk-web/src/main/java/de/sustineo/simdesk/services/dashboard/DashboardService.java | Deleted dashboard service |
| simdesk-web/src/main/java/de/sustineo/simdesk/services/livetiming/*.java | Deleted live timing processing and state services |
| simdesk-web/src/main/java/de/sustineo/simdesk/views/components/BadgeComponentFactory.java | Removed live badge component method |
| simdesk-web/src/main/java/de/sustineo/simdesk/views/DashboardView.java | Deleted dashboard list view |
| simdesk-web/src/main/java/de/sustineo/simdesk/views/DashboardDetailedView.java | Deleted dashboard detail view |
| simdesk-web/src/main/java/de/sustineo/simdesk/views/forms/DashboardEditForm.java | Deleted dashboard edit form |
| simdesk-web/src/main/resources/db/migration/postgres/V2_9_0__remove_dashboards.sql | Migration to drop dashboard table for PostgreSQL |
| simdesk-web/src/main/resources/db/migration/sqlite/V2_9_0__remove_dashboards.sql | Migration to drop dashboard table for SQLite |
| simdesk-desktop/* | Complete deletion of desktop client module |
| .idea/runConfigurations/*.xml | Removed live timing profile and desktop client run configuration |
| .python-version | Removed Python version file |
Files not reviewed (3)
- .idea/runConfigurations/Desktop_Client.xml: Language not supported
- .idea/runConfigurations/Development_PostgreSQL.xml: Language not supported
- .idea/runConfigurations/Development_SQLite.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Unfortunatly the implementation of the live timing feature did not went well. It was very complicated and introduces a significant overhead to the entire project. Therefore, I have decided to discontinue this feature and focus on the core features of SimDesk and incorporate new features.
This pull request removes the entire
simdesk-desktopmodule and updates several project configuration files accordingly. The main impact is the complete deletion of all desktop client source code, its build configuration, and related files.Desktop client removal:
simdesk-desktop/src/main/java, including application entry points, configuration management, event bus, logging, socket client, and protocol classes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]build.gradle) and properties file (gradle.properties) for the desktop client. [1] [2].gitignoreto no longer ignore the desktop client properties file, since it is no longer relevant.Project configuration updates:
.idea/runConfigurations/Desktop_Client.xml).acc-live-timingprofile from both PostgreSQL and SQLite configurations. [1] [2].python-versionfile, indicating Python is no longer required for this project.