Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SessionFileService to use a centralized EncodingUtils utility class for handling character encoding during manual session file uploads. This eliminates duplicate encoding logic and improves maintainability by consolidating BOM handling, control character removal, and multi-charset detection into a shared utility.
- Replaced custom
readFile(),removeBOM(), andremoveControlCharacters()methods withEncodingUtils.bytesToString() - Removed the
IOExceptionimport as it's no longer explicitly referenced in this file - Simplified the file reading logic from multiple methods to a single utility call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simdesk-web/src/main/java/de/sustineo/simdesk/services/leaderboard/SessionFileService.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.