fix(installer): add zip extension to requirements check (#117)#118
fix(installer): add zip extension to requirements check (#117)#118fabiodalez-dev merged 1 commit intomainfrom
Conversation
The updater already guards against missing ZipArchive at runtime, but the
installer step 1 did not surface this as a missing requirement. Users who
installed without the zip extension would only discover the gap when trying
to apply an update (HTTP 500). Now both the UI requirements list and the
Validator class include extension_loaded('zip') so the gap is caught before
installation completes.
Fixes #117
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAggiunto un controllo per l'estensione PHP ChangesValidazione estensioni
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.51)PHPStan was skipped because the sandbox runner could not parse its output. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
…AD3, fix broken links - Fix broken links: create guida/arricchimento.md and en/guide/bulk-enrichment.md - Add guida/dischi.md + en/guide/discs.md: media types, dynamic labels, Discogs/MusicBrainz/Deezer plugins - Add guida/collane.md + en/guide/series.md: series hierarchy (cycles, seasons, spin-offs) from v0.5.9.6 - Update guida/archivi.md + en/guide/archives.md: unified search (PR #120) + interoperability section (OAI-PMH 2.0, Dublin Core XML, EAD3 bulk export — PR #127) - Update _sidebar.md + en/_sidebar.md: add Dischi/Discs and Collane/Series entries - Update changelog: add v0.5.9.6 entry (series hierarchy) and "In arrivo" section (PR #118/119/120/127) - Update tecnico/requisiti.md + en/technical/requirements.md: note on zip extension installer check (PR #118)
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Summary
extension_loaded('zip')to the installer step-1 requirements list (UI)'zip' => extension_loaded('zip')toValidator::validateSystemRequirements()(logic)The
Updateralready guards against missingZipArchiveat runtime, but the installer never surfaced this as a missing requirement. Users who installed on a server without the zip extension would only discover the gap when applying an update (HTTP 500), not at install time.Test plan
zipPHP extension → installer step 1 should now show "Zip Extension ✗ Not met" and block the "Next" buttonzipextension → no change in behaviour, requirement shows ✓Fixes #117
Summary by CodeRabbit