Replay subject#10
Open
triandco wants to merge 4 commits intofable-hub:mainfrom
Open
Conversation
triandco
commented
Sep 7, 2023
triandco
commented
- Implemented a variant of a subject that "replays" old values to new subscribers by emitting them when they first subscribe
- Added two new test cases based on RxJs
triandco
commented
Sep 7, 2023
Comment on lines
+128
to
+130
| // TODO: How should I be yielding here so that obv1.Notifications is populated? | ||
| // (I specifically don't want to emit a completion.) | ||
| do! Async.Sleep 1_000 |
Author
There was a problem hiding this comment.
@dbrattli is there a better way to ensure the value is yielded without using Async.Sleep?
Collaborator
There was a problem hiding this comment.
I'll have a look, but currently on vacation so might take a few days 😬
NickDarvey
reviewed
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 47.63% 50.67% +3.03%
==========================================
Files 14 14
Lines 1100 1188 +88
Branches 44 46 +2
==========================================
+ Hits 524 602 +78
- Misses 564 572 +8
- Partials 12 14 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.