Conversation
reese
force-pushed
the
reese-clap-update
branch
from
004675c to
6404183
Compare
froydnj
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says -- our current version of clap also has a dependency on the
attycrate (see #480 for the removal of our direct usage), so this update gets rid of our other indirect dependency on it. Plus the good hygiene of keeping our dependencies up to date.We have CLI tests to validate the output, and from looking through the
clapchangelog I don't see any changes that should affect our usage of the library, especially since our usage is pretty straightforward.