Conversation
froydnj
approved these changes
Mar 17, 2026
Collaborator
froydnj
left a comment
There was a problem hiding this comment.
I assume we have good test coverage for this?
Collaborator
Author
|
Yeah, this should be covered pretty thoroughly by the string literals stress test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, any time we convert a string to use double quotes, we compile and run a regex for every string. Benchmarking the large test fixtures,
Regex::newalone takes up more than 2% of the overall runtime, withsingle_to_double_quotedtaking up 3.5%. We could cache these or precompile the most common ones, but honestly using a regex here is overkill -- we're basically just checking for slashes followed by one of the delimiters, which we could do by iterating over the characters instead.Replacing the
fancy-regexusage with a manual implementation showssingle_to_double_quotedgoing from 3.5% -> 0.5% in my benchmarking, plus it's one fewer dependency.(This is also part of #832, since
fancy-regextakes UTF-8 strings.)