Issues identified during network tests #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibaldin
approved these changes
Jul 21, 2021
Contributor
ibaldin
left a comment
ibaldin
left a comment
There was a problem hiding this comment.
Approved. Comments are for the future.
| self.future_lock = threading.Condition() | ||
| self.stopped = False | ||
| from fabric_cf.actor.core.container.globals import GlobalsSingleton | ||
| self.log_config = GlobalsSingleton.get().get_config().get_global_config().get_logging() |
Contributor
There was a problem hiding this comment.
Lol. that's the longest invocation chain I've seen in a while. NOOP
Contributor
|
Thanks for all the figures in the documentation. Really nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#113