Update maven-assembly-plugin version

[johanblumenberg]

Description

There are newer versions of maven-assembly-plugin available.

The currently used version is maven-assembly-plugin:3.1.0, which has a compile dependency to maven-core:3.0, which means that maven-core:3.0 will be pulled down when you run the build.

maven-assembly-plugin:3.4.0 has changed this to be a provided dependency.

Updating the dependency to maven-assembly-plugin to version 3.4.0 or higher would avoid downloading maven-core:3.0 when building.

Info

• docker-maven-plugin version : 0.45.0
• Maven version (mvn -v) : 3.8.4
• Docker version : 20.10.11, build dea9396

[rohanKanojia]

@johanblumenberg : Thanks for reporting, Do you know if there are any breaking changes in 3.4.0 ?

[johanblumenberg]

@johanblumenberg : Thanks for reporting, Do you know if there are any breaking changes in 3.4.0 ?

There are some API changes that causes compile errors in docker-maven-plugin, but I did not dig any deeper into it.

[cstamas]

#1851 should solve this

[johanblumenberg]

@cstamas @rohanKanojia I see that #1851 is merged, but not released yet? Is there anything blocking a new release containing this?

[cstamas]

I don't manage this project, am just contributor. Unsure about its release cadence....

[rohanKanojia]

@cstamas @johanblumenberg : I will try to cut a new release this weekend.

[rohanKanojia]

@johanblumenberg : Hello, The new version 0.47.0 has been published to Maven Central. Could you please try it out and let us know if everything is working as expected?

[johanblumenberg]

@rohanKanojia Thank you 🙏

I can confirm it is working. The docker plugin no longer downloads maven-core when running.

Version 0.46.0:

[INFO] --- docker:0.46.0:start (prepare) @ test-jar ---
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.0/maven-core-3.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.0/maven-core-3.0.pom (6.6 kB at 276 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.0/maven-core-3.0.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.0/maven-core-3.0.jar (527 kB at 15 MB/s)

Version 0.47.0:

[INFO] --- docker:0.47.0:start (prepare) @ test-jar ---

[rohanKanojia]

@johanblumenberg : Thanks for giving it a try! Shall we close this issue then?

[johanblumenberg]

@johanblumenberg : Thanks for giving it a try! Shall we close this issue then?

yes, feel free to close 👍