Skip to content

R: fix OpenMP detection on macOS with GCC#96

Merged
fabsig merged 1 commit intofabsig:masterfrom
barracuda156:darwin
Jun 16, 2023
Merged

R: fix OpenMP detection on macOS with GCC#96
fabsig merged 1 commit intofabsig:masterfrom
barracuda156:darwin

Conversation

@barracuda156
Copy link
Contributor

Fixes: #95

@barracuda156 barracuda156 marked this pull request as draft June 15, 2023 06:04
@barracuda156
Copy link
Contributor Author

barracuda156 commented Jun 15, 2023

Gimme a min, it also has to be removed from PKG_LIBS, otherwise linking is left broken.

UPD. Should be made conditional on compiler, otherwise configure forces linking to non-existing libomp. Eh.

@barracuda156
Copy link
Contributor Author

Everything working now.

R version 4.3.0 (2023-04-21) -- "Already Tomorrow"
Copyright (C) 2023 The R Foundation for Statistical Computing
Platform: powerpc-apple-darwin10.0.0d2 (32-bit)

> library(testthat)
> library(gpboost)
Loading required package: R6
> 
> test_check(
+     package = "gpboost"
+     , stop_on_failure = TRUE
+     , stop_on_warning = FALSE
+ )
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 728 ]
> 
> proc.time()
   user  system elapsed 
 97.189  24.973  91.253 

P. S. PowerPC also needs a fix for Eigen, since GPBoost at the moment uses an old version of its headers where Altivec/VSX bug is not fixed.

@fabsig fabsig marked this pull request as ready for review June 16, 2023 12:37
@fabsig fabsig merged commit 2bacb71 into fabsig:master Jun 16, 2023
@barracuda156 barracuda156 deleted the darwin branch June 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Detecting OpenMP support does not work correctly on macOS when building with GCC

2 participants