chore: set up linting and formatting infrastructure#34
Merged
Pinkish-Warrior merged 2 commits intomainfrom Dec 15, 2025
Merged
Conversation
- Add ESLint with TypeScript support and strict rules - Add Prettier for consistent code formatting (80 char, double quotes, LF) - Add Husky git hooks (pre-commit: lint-staged, pre-push: type-check) - Add lint-staged for efficient staged file checking - Add markdownlint for documentation consistency - Add EditorConfig for cross-OS/IDE consistency - Create comprehensive LINTS.md developer guide - Update package.json with lint, format, type-check, and validate scripts This ensures code quality and consistency across the team of 4 developers working on different operating systems. Note: Pre-push hook temporarily excludes tests until Vitest setup is complete.
MariShopen
reviewed
Dec 12, 2025
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| # Run lint-staged for backend | ||
| cd backend && npx lint-staged |
Contributor
There was a problem hiding this comment.
I have a big question about using Husky. I don’t think it’s necessary, and I’m worried it will actually make our work more complicated. It’s much more convenient to make intermediate commits without thinking about the linter every time, and then run one general check before pushing. So I suggest we remove .husky/pre-commit.
Contributor
Author
|
Hi Marina,Thank you for input on this. What is exactly the complication you see on this - Could you explain further? Husky handles the task for you automatically, ensuring nothing is forgotten and preventing issues from being pushed to the CI/CD pipeline, which could slow down development. Looking forward on hearing your thoughts, Tania Rosa SantanaShe/herOn 12 Dec 2025, at 19:42, Marina Shopina ***@***.***> wrote:
@MariShopen commented on this pull request.
In .husky/pre-commit:
@@ -0,0 +1,5 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+# Run lint-staged for backend
+cd backend && npx lint-staged
I have a big question about using Husky. I don’t think it’s necessary, and I’m worried it will actually make our work more complicated. It’s much more convenient to make intermediate commits without thinking about the linter every time, and then run one general check before pushing. So I suggest we remove .husky/pre-commit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
MariShopen
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures code quality and consistency across the team of 4 developers working on different operating systems.
Note: Pre-push hook temporarily excludes tests until Vitest setup is complete.