Replace checked_cast with pyre_extensions assert_is_instance#3229
Closed
eonofrey wants to merge 1 commit into
Closed
Replace checked_cast with pyre_extensions assert_is_instance#3229eonofrey wants to merge 1 commit into
checked_cast with pyre_extensions assert_is_instance#3229eonofrey wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67879879 |
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 13, 2025
…ebook#3229) Summary: Pull Request resolved: facebook#3229 Replace `checked_cast` with pyre_extensions `assert_is_instance` Search for all use cases with "ax.utils.common.typeutils .* checked_cast" regex Differential Revision: D67879879
eonofrey
force-pushed
the
export-D67879879
branch
from
7183bdf to
4220d9a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67879879 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3229 +/- ##
==========================================
- Coverage 95.88% 95.88% -0.01%
==========================================
Files 513 513
Lines 51710 51660 -50
==========================================
- Hits 49580 49532 -48
+ Misses 2130 2128 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67879879 |
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 15, 2025
…ebook#3229) Summary: Pull Request resolved: facebook#3229 Replace `checked_cast` with pyre_extensions `assert_is_instance` Search for all use cases with "ax.utils.common.typeutils .* checked_cast" regex Differential Revision: D67879879
eonofrey
force-pushed
the
export-D67879879
branch
from
4220d9a to
b8e84c2
Compare
…ebook#3229) Summary: Pull Request resolved: facebook#3229 Replace `checked_cast` with pyre_extensions `assert_is_instance` Search for all use cases with "ax.utils.common.typeutils .* checked_cast" regex Differential Revision: D67879879
eonofrey
force-pushed
the
export-D67879879
branch
from
b8e84c2 to
f5f121c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67879879 |
Contributor
|
This pull request has been merged in ca93faa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace
checked_castwith pyre_extensionsassert_is_instanceSearch for all use cases with "ax.utils.common.typeutils .* checked_cast" regex
Differential Revision: D67879879