DerivedParameter #4142
Closed
DerivedParameter #4142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 18, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
29cff08 to
ab2c064
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
==========================================
+ Coverage 96.15% 96.16% +0.01%
==========================================
Files 562 564 +2
Lines 57058 57290 +232
==========================================
+ Hits 54863 55092 +229
- Misses 2195 2198 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 20, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
ab2c064 to
1bf562d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 20, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
1bf562d to
f3ae5bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 20, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
f3ae5bb to
d210ae3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
force-pushed
the
export-D80252960
branch
from
d210ae3 to
418b84f
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 20, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Differential Revision: D80252960
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
force-pushed
the
export-D80252960
branch
from
418b84f to
5d51dd0
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 25, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Reviewed By: lena-kashtelyan Differential Revision: D80252960
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 25, 2025
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Reviewed By: lena-kashtelyan Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
5d51dd0 to
782969a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
Summary: * This adds support for derived parameters that are linear functions of other parameters. * This uses sympy to enable non-linear parameter definitions in the future * This updates `RemoveFixed` to also remove/add derived parameters. * This updates json/sqa storage for the new parameter type * This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter). Reviewed By: lena-kashtelyan Differential Revision: D80252960
sdaulton
force-pushed
the
export-D80252960
branch
from
782969a to
9d402bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80252960 |
1 task
Contributor
|
This pull request has been merged in b65e24c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for derived parameters that are linear functions of other parameters.
This updates
RemoveFixedto also remove/add derived parameters.This updates json/sqa storage for the new parameter type
This updates core stubs to include a derived parameter (so that SQA storage tests include a derived parameter).
Differential Revision: D80252960