Skip to content

Enable BoTorch-based BenchmarkProblems with MapMetric#4252

Closed
esantorella wants to merge 1 commit into
facebook:mainfrom
esantorella:export-D81689093
Closed

Enable BoTorch-based BenchmarkProblems with MapMetric#4252
esantorella wants to merge 1 commit into
facebook:mainfrom
esantorella:export-D81689093

Conversation

@esantorella
Copy link
Copy Markdown
Contributor

Summary:

  • Enables BoTorchTestFunction to produce data with steps and MapMetric. The data is simply repeated, so this is not interesting for modeling, but it is useful for measuring runtime.
  • Makes outputs 2d in accordance with the docstring.

Differential Revision: D81689093

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 4, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81689093

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.12%. Comparing base (70524f0) to head (838f4ae).
⚠️ Report is 722 commits behind head on main.

Files with missing lines Patch % Lines
...hmark_test_functions/test_botorch_test_function.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4252      +/-   ##
==========================================
- Coverage   96.12%   96.12%   -0.01%     
==========================================
  Files         566      566              
  Lines       57671    57701      +30     
==========================================
+ Hits        55439    55467      +28     
- Misses       2232     2234       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

esantorella added a commit to esantorella/Ax that referenced this pull request Sep 4, 2025
Summary:

* Enables BoTorchTestFunction to produce data with `steps` and `MapMetric`. The data is simply repeated, so this is not interesting for modeling, but it is useful for measuring runtime.
* Makes outputs 2d in accordance with the docstring.

Reviewed By: saitcakmak

Differential Revision: D81689093
Summary:
Pull Request resolved: facebook#4252

* Enables BoTorchTestFunction to produce data with `steps` and `MapMetric`. The data is simply repeated, so this is not interesting for modeling, but it is useful for measuring runtime.
* Makes outputs 2d in accordance with the docstring.

Reviewed By: saitcakmak

Differential Revision: D81689093
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D81689093

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 8d3c1c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants