Skip to content

Tighten TopSurfacesAnalysis.validate_applicable_state#4541

Closed
mpolson64 wants to merge 1 commit into
facebook:mainfrom
mpolson64:export-D87089811
Closed

Tighten TopSurfacesAnalysis.validate_applicable_state#4541
mpolson64 wants to merge 1 commit into
facebook:mainfrom
mpolson64:export-D87089811

Conversation

@mpolson64
Copy link
Copy Markdown
Contributor

Summary: Add checks for experiment having trials, data, that the metric name is present on the data, and that the current adapter is the TorchAdapter since Sensitivity will fail if the adapter is anything but the TorchAdapter

Differential Revision: D87089811

Summary: Add checks for experiment having trials, data, that the metric name is present on the data, and that the current adapter is the TorchAdapter since Sensitivity will fail if the adapter is anything but the TorchAdapter

Differential Revision: D87089811
@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 14, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Nov 14, 2025

@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87089811.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.58%. Comparing base (13eb606) to head (42d6685).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ax/analysis/plotly/top_surfaces.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4541   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files         548      548           
  Lines       56496    56523   +27     
=======================================
+ Hits        54563    54590   +27     
  Misses       1933     1933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Nov 18, 2025

This pull request has been merged in 459f0bf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants