Port is_unordered_choice and can_map_to_binary to OSS #4645
+165
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88883178. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4645 +/- ##
==========================================
- Coverage 96.53% 96.53% -0.01%
==========================================
Files 565 565
Lines 58996 59027 +31
==========================================
+ Hits 56952 56981 +29
- Misses 2044 2046 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
force-pushed
the
export-D88883178
branch
from
5844b83 to
adee6c3
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 11, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
force-pushed
the
export-D88883178
branch
from
adee6c3 to
cafedcf
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Dec 12, 2025
… is_unordered_choice, can_map_to_binary (facebook#4645) Summary: Pull Request resolved: facebook#4645 Reviewed By: bernardbeckerman Differential Revision: D88883178
|
This pull request has been merged in 89b35c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D88883178