Move analysis_card to ax/core#4647
Closed
mpolson64 wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88860614. |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#4647 Motivated by storage work, where we want the AnalysisCard to become a true member of Ax's data model rather than needing to be saved a-la-carte via helper methods. In the future we will being saving AnalysisCards as attributes on the experiment so they can be (lazy) loaded together by default. Note that we are only moving the base AnalysisCard subclasses, not requireing Plotly, Graphviz, Markdown, etc -- those subclasses will remain in Analysis along with the concrete Analyses. Also note that no notebook users would have any use for importing AnalysisCard directly (they import concrete Analyses if anything), so we should not worry about any disruption there Reviewed By: Cesar-Cardoso Differential Revision: D88860614
mpolson64
force-pushed
the
export-D88860614
branch
from
6be349f to
e4c923c
Compare
Summary: Pull Request resolved: facebook#4647 Motivated by storage work, where we want the AnalysisCard to become a true member of Ax's data model rather than needing to be saved a-la-carte via helper methods. In the future we will being saving AnalysisCards as attributes on the experiment so they can be (lazy) loaded together by default. Note that we are only moving the base AnalysisCard subclasses, not requireing Plotly, Graphviz, Markdown, etc -- those subclasses will remain in Analysis along with the concrete Analyses. Also note that no notebook users would have any use for importing AnalysisCard directly (they import concrete Analyses if anything), so we should not worry about any disruption there Reviewed By: Cesar-Cardoso Differential Revision: D88860614
mpolson64
force-pushed
the
export-D88860614
branch
from
e4c923c to
a0015eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 567 567
Lines 59104 59103 -1
=======================================
+ Hits 57054 57055 +1
+ Misses 2050 2048 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in fa1f703. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivated by storage work, where we want the AnalysisCard to become a true member of Ax's data model rather than needing to be saved a-la-carte via helper methods. In the future we will being saving AnalysisCards as attributes on the experiment so they can be (lazy) loaded together by default.
Note that we are only moving the base AnalysisCard subclasses, not requireing Plotly, Graphviz, Markdown, etc -- those subclasses will remain in Analysis along with the concrete Analyses.
Also note that no notebook users would have any use for importing AnalysisCard directly (they import concrete Analyses if anything), so we should not worry about any disruption there
Differential Revision: D88860614