Make ParameterConstraint store its own inequality string#4658
Closed
mpolson64 wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
- Coverage 96.53% 96.53% -0.01%
==========================================
Files 567 568 +1
Lines 59103 59136 +33
==========================================
+ Hits 57054 57085 +31
- Misses 2049 2051 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Move some of the string parsing from ax/api into core Ax to allow a ParameterConstraint to be defined and constructed from its inequality string. This will allow more flexibility in the future, but is primarily motivated by a want to store only the inequality string when saving ParameterConstraints and to eliminiate unnnecessary subclasses SumConstraint and OrderConstraint Differential Revision: D88880607
mpolson64
force-pushed
the
export-D88880607
branch
from
25f1261 to
ec9ec5f
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Move some of the string parsing from ax/api into core Ax to allow a ParameterConstraint to be defined and constructed from its inequality string. This will allow more flexibility in the future, but is primarily motivated by a want to store only the inequality string when saving ParameterConstraints and to eliminiate unnnecessary subclasses SumConstraint and OrderConstraint Reviewed By: saitcakmak Differential Revision: D88880607
mpolson64
force-pushed
the
export-D88880607
branch
from
ec9ec5f to
6f4f3f2
Compare
Summary: Move some of the string parsing from ax/api into core Ax to allow a ParameterConstraint to be defined and constructed from its inequality string. This will allow more flexibility in the future, but is primarily motivated by a want to store only the inequality string when saving ParameterConstraints and to eliminiate unnnecessary subclasses SumConstraint and OrderConstraint Reviewed By: saitcakmak Differential Revision: D88880607
mpolson64
force-pushed
the
export-D88880607
branch
from
6f4f3f2 to
c365e21
Compare
|
This pull request has been merged in 873a012. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move some of the string parsing from ax/api into core Ax to allow a ParameterConstraint to be defined and constructed from its inequality string.
This will allow more flexibility in the future, but is primarily motivated by a want to store only the inequality string when saving ParameterConstraints and to eliminiate unnnecessary subclasses SumConstraint and OrderConstraint
Differential Revision: D88880607