Replace SumConstraint with ParameterConstraint#4660
Closed
mpolson64 wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88897672. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
==========================================
- Coverage 96.53% 96.52% -0.02%
==========================================
Files 567 568 +1
Lines 59113 58953 -160
==========================================
- Hits 57064 56903 -161
- Misses 2049 2050 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#4660 Same as D88890559 but for SumConstraint Reviewed By: saitcakmak Differential Revision: D88897672
mpolson64
force-pushed
the
export-D88897672
branch
2 times, most recently
from
6205d26 to
701a683
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#4660 Same as D88890559 but for SumConstraint Reviewed By: saitcakmak Differential Revision: D88897672
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#4660 Same as D88890559 but for SumConstraint Reviewed By: saitcakmak Differential Revision: D88897672
mpolson64
force-pushed
the
export-D88897672
branch
from
701a683 to
20b2a4e
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Dec 15, 2025
Summary: Pull Request resolved: facebook#4660 Same as D88890559 but for SumConstraint Reviewed By: saitcakmak Differential Revision: D88897672
mpolson64
force-pushed
the
export-D88897672
branch
from
20b2a4e to
db23a66
Compare
Summary: Move some of the string parsing from ax/api into core Ax to allow a ParameterConstraint to be defined and constructed from its inequality string. This will allow more flexibility in the future, but is primarily motivated by a want to store only the inequality string when saving ParameterConstraints and to eliminiate unnnecessary subclasses SumConstraint and OrderConstraint Differential Revision: D88880607
Differential Revision: D88890559
Summary: Pull Request resolved: facebook#4660 Same as D88890559 but for SumConstraint Reviewed By: saitcakmak Differential Revision: D88897672
mpolson64
force-pushed
the
export-D88897672
branch
from
db23a66 to
b5de968
Compare
|
This pull request has been merged in 47a5e0c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Same as D88890559 but for SumConstraint
Differential Revision: D88897672