Debug testutils._build_comparison_str#4724
Closed
lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Closed
Debug testutils._build_comparison_str#4724lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
testutils._build_comparison_str#4724lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89909334. |
meta-cla
bot
added
the
CLA Signed
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 30, 2025
Summary:
Previously we could get absent (and thus confusing) output in some edge cases (unequal type in top-level objects; unequal type for two instances of Ax `Base); this covers.
{F1984377139}
Reviewed By: mgarrard
Differential Revision: D89909334
lena-kashtelyan
force-pushed
the
export-D89909334
branch
from
3bfb5c4 to
92c91d7
Compare
Summary:
Previously we could get absent (and thus confusing) output in some edge cases (unequal type in top-level objects; unequal type for two instances of Ax `Base); this covers.
{F1984377139}
Reviewed By: mgarrard
Differential Revision: D89909334
lena-kashtelyan
force-pushed
the
export-D89909334
branch
from
92c91d7 to
51dca7e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4724 +/- ##
==========================================
- Coverage 96.72% 96.72% -0.01%
==========================================
Files 582 582
Lines 60683 60690 +7
==========================================
+ Hits 58697 58701 +4
- Misses 1986 1989 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in fd38b65. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we could get absent (and thus confusing) output in some edge cases (unequal type in top-level objects; unequal type for two instances of Ax `Base); this covers.
{F1984377139}
Differential Revision: D89909334