Update reset_gs code to orphan old gs if not indicated for deletion#4735
Closed
mgarrard wants to merge 1 commit into
Closed
Update reset_gs code to orphan old gs if not indicated for deletion#4735mgarrard wants to merge 1 commit into
mgarrard wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 582 582
Lines 60679 60699 +20
=======================================
+ Hits 58691 58713 +22
+ Misses 1988 1986 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 5, 2026
…acebook#4735) Summary: V2: After review we decided to allow for multiple GS to be associated with an experiment in the db and only load the most recent one. V1: I was looking at this method and realized that although it will work within a single instance of client, upon saving/re-loading the experiment load will fail because there will be two instances of gs associated with an experiment and this will cause a merge error. This implements: 1. an orphan gs method -- allows the legacy gs to still live in the db and just sets expeirment column to none, essentially orphaning it, but we coud go look it up in the future if we wanted 2. cleans up some pyres taht weren't doing anything i saw along the way 3. extends tests to account for this behavior Reviewed By: mpolson64 Differential Revision: D90064851
mgarrard
force-pushed
the
export-D90064851
branch
from
fdbd0ac to
beed1f2
Compare
…acebook#4735) Summary: V2: After review we decided to allow for multiple GS to be associated with an experiment in the db and only load the most recent one. V1: I was looking at this method and realized that although it will work within a single instance of client, upon saving/re-loading the experiment load will fail because there will be two instances of gs associated with an experiment and this will cause a merge error. This implements: 1. an orphan gs method -- allows the legacy gs to still live in the db and just sets expeirment column to none, essentially orphaning it, but we coud go look it up in the future if we wanted 2. cleans up some pyres taht weren't doing anything i saw along the way 3. extends tests to account for this behavior Reviewed By: mpolson64 Differential Revision: D90064851
mgarrard
force-pushed
the
export-D90064851
branch
from
beed1f2 to
b13342e
Compare
|
This pull request has been merged in 60f5ca9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I was looking at this method and realized that although it will work within a single instance of client, upon saving/re-loading the experiment load will fail because there will be two instances of gs associated with an experiment and this will cause a merge error.
This implements:
Differential Revision: D90064851