Increase restritiveness of data requirements for TrialBasedCriteria #4802
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4802 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 586
Lines 61320 61321 +1
=======================================
+ Hits 59306 59307 +1
Misses 2014 2014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
force-pushed
the
export-D91064377
branch
from
f4d3abb to
4a5f501
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 24, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
force-pushed
the
export-D91064377
branch
from
4a5f501 to
fe41dd0
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 26, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 26, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
force-pushed
the
export-D91064377
branch
from
fe41dd0 to
c6710ff
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc.
We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths
Differential Revision: D91064377