Skip to content

Remove AxClient._get_pending_observation_features #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saitcakmak wants to merge 1 commit into from
Closed

Remove AxClient._get_pending_observation_features #4872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ax/service/ax_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from ax.core.trial import Trial
from ax.core.trial_status import TrialStatus
from ax.core.types import TEvaluationOutcome, TParameterization, TParamValue
from ax.core.utils import get_pending_observation_features_based_on_trial_status
from ax.early_stopping.strategies import BaseEarlyStoppingStrategy
from ax.early_stopping.utils import estimate_early_stopping_savings
from ax.exceptions.constants import CHOLESKY_ERROR_ANNOTATION
Expand Down Expand Up @@ -1677,22 +1676,6 @@ def _validate_all_required_metrics_present(
missing_metrics = required_metrics - provided_metrics
return not missing_metrics

@classmethod
def _get_pending_observation_features(
cls,
experiment: Experiment,
) -> dict[str, list[ObservationFeatures]] | None:
"""Extract pending points for the given experiment.

NOTE: With one-arm `Trial`-s, we use a more performant
``get_pending_observation_features_based_on_trial_status`` utility instead
of ``get_pending_observation_features``, since we can determine whether a point
is pending based on the status of the corresponding trial.
"""
return get_pending_observation_features_based_on_trial_status(
experiment=experiment
)

# ------------------------------ Validators. -------------------------------

def _validate_early_stopping_strategy(
Expand Down