Back out "Phase 3: Add Self type annotations to fluent/clone methods"#4882
Closed
Balandat wants to merge 1 commit intofacebook:mainfrom
Closed
Back out "Phase 3: Add Self type annotations to fluent/clone methods"#4882Balandat wants to merge 1 commit intofacebook:mainfrom
Balandat wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Unlanding this temporarily for compatibility reasons. Differential Revision: D92858617
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4882 +/- ##
=======================================
Coverage 96.75% 96.76%
=======================================
Files 591 591
Lines 61955 61950 -5
=======================================
- Hits 59947 59943 -4
+ Misses 2008 2007 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 541c458. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Unlanding this temporarily for compatibility reasons.
Differential Revision: D92858617