Rename num_parallel_jobs to num_concurrent_jobs in BenchmarkExecutionSettings#4924
Closed
mgrange1998 wants to merge 2 commits intofacebook:mainfrom
Closed
Rename num_parallel_jobs to num_concurrent_jobs in BenchmarkExecutionSettings#4924mgrange1998 wants to merge 2 commits intofacebook:mainfrom
mgrange1998 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mgrange1998
force-pushed
the
export-D93771883
branch
from
bcc4bd3 to
b25c159
Compare
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93771883. |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ings (facebook#4924) Summary: Updates docstrings in `BenchmarkMethod`, `BenchmarkExecutionSettings`, and `nightly.py` to use "concurrency" terminology instead of "parallelism" where appropriate. Also applies a formatting fix to a multi-line `BenchmarkExecutionSettings(...)` call in `nightly.py`. No interface or behavioral changes. Differential Revision: D93771883
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ings (facebook#4924) Summary: Updates docstrings in `BenchmarkMethod`, `BenchmarkExecutionSettings`, and `nightly.py` to use "concurrency" terminology instead of "parallelism" where appropriate. Also applies a formatting fix to a multi-line `BenchmarkExecutionSettings(...)` call in `nightly.py`. No interface or behavioral changes. Differential Revision: D93771883
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4924 +/- ##
==========================================
- Coverage 96.85% 96.85% -0.01%
==========================================
Files 597 597
Lines 63664 63668 +4
==========================================
+ Hits 61664 61667 +3
- Misses 2000 2001 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Reviewed By: saitcakmak Differential Revision: D93771849
…ings (facebook#4924) Summary: Updates docstrings in `BenchmarkMethod`, `BenchmarkExecutionSettings`, and `nightly.py` to use "concurrency" terminology instead of "parallelism" where appropriate. Also applies a formatting fix to a multi-line `BenchmarkExecutionSettings(...)` call in `nightly.py`. No interface or behavioral changes. Reviewed By: saitcakmak Differential Revision: D93771883
mgrange1998
force-pushed
the
export-D93771883
branch
from
b25c159 to
401cbfb
Compare
|
This pull request has been merged in 1cd0b89. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Renames
num_parallel_jobstonum_concurrent_jobsinBenchmarkExecutionSettingsand all nightly benchmark configurations. Also updates the docstring inBenchmarkMethodto reference "pending trials" instead of "parallelism". This is a mechanical rename with no behavioral change.Differential Revision: D93771883