Allow Oracle Experiment to take ABANDONED trials into account#4953
Open
sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
Open
Allow Oracle Experiment to take ABANDONED trials into account#4953sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86833965. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4953 +/- ##
========================================
Coverage 96.84% 96.85%
========================================
Files 596 596
Lines 63480 63596 +116
========================================
+ Hits 61478 61593 +115
- Misses 2002 2003 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4953) Summary: Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization. Differential Revision: D86833965
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4953) Summary: Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization. Differential Revision: D86833965
sunnyshen321
force-pushed
the
export-D86833965
branch
from
66f48d8 to
2ec71c2
Compare
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Mar 3, 2026
…ok#4953) Summary: Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization. Differential Revision: D86833965
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Mar 3, 2026
…ok#4953) Summary: Pull Request resolved: facebook#4953 Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization. Differential Revision: D86833965
sunnyshen321
force-pushed
the
export-D86833965
branch
from
2ec71c2 to
16532a7
Compare
…ok#4953) Summary: Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization. Differential Revision: D86833965
sunnyshen321
force-pushed
the
export-D86833965
branch
from
16532a7 to
1e4ee2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Include ABANDONED trials in the trace by carrying forward the last best value. This ensures the trace has one value per trial, reflecting that ABANDONED trials consumed resources but didn't improve optimization.
Differential Revision: D86833965