Validate candidates generated by Acquisition.optimize#4972
Open
dme65 wants to merge 2 commits intofacebook:mainfrom
Open
Validate candidates generated by Acquisition.optimize#4972dme65 wants to merge 2 commits intofacebook:mainfrom
dme65 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Mar 4, 2026
Summary: This adds validation to `Acquisition.optimize` to make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch. Differential Revision: D95078354
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Mar 5, 2026
Summary: This adds validation to `Acquisition.optimize` to make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch. Differential Revision: D95078354
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Mar 5, 2026
Summary: Pull Request resolved: facebook#4972 This adds validation to `Acquisition.optimize` to make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch. Differential Revision: D95078354
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Mar 5, 2026
Summary: This adds validation to `Acquisition.optimize` to make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch. Reviewed By: saitcakmak Differential Revision: D95078354
added 2 commits
March 4, 2026 18:41
…acebook#4971) Summary: `optimize_with_nsgaii` may produce invalid candidates as it currently doesn't support discrete parameters (treated as floats), inequality constraints (completely ignored), and post processing functions (also ignored). These features were added to BoTorch as part of this diff stack. Here we update Ax to pass down the relevant parameters to `optimize_with_nsgaii` which ensures the generated candidates are within the search space. Reviewed By: sdaulton, saitcakmak Differential Revision: D95243318
Summary: This adds validation to `Acquisition.optimize` to make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch. Reviewed By: saitcakmak Differential Revision: D95078354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This adds validation to
Acquisition.optimizeto make sure the generated candidates satisfy the bounds, values specified by choice parameters, and potential parameter constraints. This will allow us to catch potential downstream errors in the acquisition function optimization in BoTorch.Differential Revision: D95078354